Skip to content

(release/25.0) glamor: Set need_free_region immediately after pixman region allocation - #4012

Open
metux wants to merge 1 commit into
release/25.0from
pr/release/25.0-glamor-set-need-free-region-immediately-after-pixman-region-allocation-_2026-10-16_20-11-25
Open

metux wants to merge 1 commit into
release/25.0from
pr/release/25.0-glamor-set-need-free-region-immediately-after-pixman-region-allocation-_2026-10-16_20-11-25

Conversation

@metux

@metux metux commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Otherwise, the region would leak when the pixmap is not in gpu memory

Signed-off-by: stefan11111 stefan11111github@gmail.com
Part-of: https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2289
(cherry picked from commit 41b3d99)

…tion

Otherwise, the region would leak when the pixmap is not in gpu memory

Signed-off-by: stefan11111 <stefan11111github@gmail.com>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2289>
(cherry picked from commit 41b3d99)
@metux metux self-assigned this Oct 16, 2026
@metux
metux requested a review from a team October 16, 2026 18:12
metux pushed a commit that referenced this pull request Oct 16, 2026
…gion allocation

Otherwise, the region would leak when the pixmap is not in gpu memory

Signed-off-by: stefan11111 <stefan11111github@gmail.com>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2289>
(cherry picked from commit 41b3d99)
PR: #4012
@metux

metux commented Oct 16, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Automated review — generated by Starfleet ship Enterprise (model: cruiser) on behalf of @metux. Not a human review.

🤖 Automated review — generated by Starfleet ship Enterprise on behalf of @metux. Not a human review.

Summary: Moves need_free_region = TRUE assignment before the early goto fallback path in glamor_composite_rectangles(). No behavioral change — just code reorganisation so the flag is set regardless of which exit path is taken.

Assessment:

  • Backport-worthiness: No - this is code reorganisation/cleanup without behavioral change. Not a bugfix, not security-critical, not backport-worthy.
  • Driver-ABI impact: No - glamor internal code, no driver-visible structures or _X_EXPORT symbols.
  • Correctness: Safe reorganisation; need_free_region is set before all paths that use it.

Label: bot-review-passed

@metux metux added the bot-review-passed Automated bot review found no blocking issues label Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot-review-passed Automated bot review found no blocking issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants