(release/25.0) xquartz: Replace assert() around side-effecting calls with unconditional error handling - #3608
Open
Conversation
…nal error handling darwin.c and bundle_trampoline.c wrapped calls that allocate memory, add input devices, or spawn a process in assert(), so building with NDEBUG would silently skip the call and leave the guarded variable uninitialized or unset while still proceeding as if it had succeeded. darwin.c now calls FatalError() on failure. bundle_trampoline runs before the server attaches to a terminal or console, so stderr is not visible there; it now logs via os_log_error() and calls abort(). Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
metux
pushed a commit
that referenced
this pull request
Aug 20, 2026
… unconditional error handling darwin.c and bundle_trampoline.c wrapped calls that allocate memory, add input devices, or spawn a process in assert(), so building with NDEBUG would silently skip the call and leave the guarded variable uninitialized or unset while still proceeding as if it had succeeded. darwin.c now calls FatalError() on failure. bundle_trampoline runs before the server attaches to a terminal or console, so stderr is not visible there; it now logs via os_log_error() and calls abort(). Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com> PR: #3608
Contributor
Author
Same correctness fix as #3575 / #3595, now on What it does: replaces ABI impact: none. Darwin-only (XQuartz). Backport candidate: same as #3575 — latent bugfix, Darwin-only. Maintainer decides. Verdict: passes review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
darwin.c and bundle_trampoline.c wrapped calls that allocate memory, add input devices, or spawn a process in
assert(), so building with NDEBUG would silently skip the call and leave the guarded variable uninitialized or
unset while still proceeding as if it had succeeded.
darwin.c now calls FatalError() on failure. bundle_trampoline runs before the server attaches to a terminal or
console, so stderr is not visible there; it now logs via os_log_error() and calls abort().
Signed-off-by: Jeremy Huddleston Sequoia jeremyhu@apple.com