(release/25.0) rootless: Fix two region leaks - #3606
Open
metux wants to merge 1 commit into
Open
Conversation
RootlessEnsureFrame returns without releasing a shaped window's region when the implementation refuses to create the frame, and RootlessMiValidateTree never releases the exposed region it hands to RootlessComputeClips -- upstream miValidateTree does. Both are longstanding. Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
metux
pushed a commit
that referenced
this pull request
Aug 20, 2026
RootlessEnsureFrame returns without releasing a shaped window's region when the implementation refuses to create the frame, and RootlessMiValidateTree never releases the exposed region it hands to RootlessComputeClips -- upstream miValidateTree does. Both are longstanding. Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com> PR: #3606
Contributor
Author
Identical cherry-pick of PR #3593 (already reviewed on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RootlessEnsureFrame returns without releasing a shaped window's region when the implementation refuses to create the
frame, and RootlessMiValidateTree never releases the exposed region it hands to RootlessComputeClips -- upstream
miValidateTree does.
Both are longstanding.
Signed-off-by: Jeremy Huddleston Sequoia jeremyhu@apple.com