(release/25.0) composite: Fix PanoramiX overlay window release

[metux]

PanoramiX overlay resources contain physical window IDs for each
screen. Look them up as regular window resources when releasing the
client's overlay reference.

Signed-off-by: Xinhao Liu liuxinhao@kylinsec.com.cn
Part-of: https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2259

[metux]

🤖 Automated review — generated by Starfleet ship Discovery on behalf of @metux. Not a human review.

Clean correctness fix — no objections.

What it does: fixes the resource lookup in ProcCompositeReleaseOverlayWindow() for PanoramiX overlay windows. Two changes in the dixLookupResourceByType call:

1. XRT_WINDOW → X11_RESTYPE_WINDOW: PanoramiX overlay resources contain physical window IDs for each screen — these are regular X11 windows, not internal composite resources. Using the standard type constant ensures correct lookup semantics.

2. DixUnknownAccess → DixGetAttrAccess: downgrades the access level from "unknown" (which can bypass resource validation) to "get attributes" — the minimum permission needed for a release operation. This is the proper access class for a read-and-release pattern.

ABI impact: none. Internal composite code, no struct or export changes.

Backport candidate: debatable — resource lookup correctness fix. Not a crash per se, but using the wrong resource type could cause false matches or lookup failures on multi-screen PanoramiX configurations. Maintainer decides.

Verdict: passes review.