Skip to content

(release/25.1) exa: silence -Wold-style-declaration warning from gcc 16 - #3589

Open
metux wants to merge 1 commit into
release/25.1from
pr/release/25.1-exa-silence-wold-style-declaration-warning-from-gcc-16-_2026-08-20_16-18-12
Open

(release/25.1) exa: silence -Wold-style-declaration warning from gcc 16#3589
metux wants to merge 1 commit into
release/25.1from
pr/release/25.1-exa-silence-wold-style-declaration-warning-from-gcc-16-_2026-08-20_16-18-12

Conversation

@metux

@metux metux commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

exa/exa_accel.c:239:1: warning: ‘inline’ is not at beginning of declaration
[-Wold-style-declaration]
239 | static Bool inline
| ^~~~~~

Signed-off-by: Alan Coopersmith alan.coopersmith@oracle.com
Part-of: https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2272

exa/exa_accel.c:239:1: warning: ‘inline’ is not at beginning of declaration
 [-Wold-style-declaration]
  239 | static Bool inline
      | ^~~~~~

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2272>
@metux metux self-assigned this Aug 20, 2026
@metux
metux requested a review from a team August 20, 2026 14:19
metux pushed a commit that referenced this pull request Aug 20, 2026
exa/exa_accel.c:239:1: warning: ‘inline’ is not at beginning of declaration
 [-Wold-style-declaration]
  239 | static Bool inline
      | ^~~~~~

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2272>
PR: #3589
@metux

metux commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

Review: exa: silence -Wold-style-declaration warning from gcc 16

Moves inline from after Bool to before it: static Bool inlinestatic inline Bool. GCC 16 warns about the old-style placement. No behavioral change.

Code review (1 file, +1/-1)

  • Standard C places inline before the return type in a function declaration. The old position was a GCC extension. Trivial fix.

Checklist

  • Driver ABI: No impact — exa-internal static function.
  • Security: Not a security fix — compiler warning cleanup.
  • Backport: Warning fix only. Already on release/25.1. Applicability to release/25.0 — maintainer decides.
  • CI: Queued, not yet completed.

Verdict

Passed. Trivial, correct fix.

@metux metux added the bot-review-passed Automated bot review found no blocking issues label Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot-review-passed Automated bot review found no blocking issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants