dbe: use REQUEST_HEAD_STRUCT and REQUEST_FIELD_* macros #1545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metux
requested review from
a team,
ONykyf,
algrid,
b-aaz,
callmetango,
cepelinas9000,
jonhermansen,
josephcrowell,
mikedld and
stefan11111
metux
added a commit
that referenced
this pull request
Dec 3, 2025
metux
added a commit
that referenced
this pull request
Dec 4, 2025
metux
added a commit
that referenced
this pull request
Dec 4, 2025
metux
added a commit
that referenced
this pull request
Dec 4, 2025
Contributor
Author
metux
added a commit
that referenced
this pull request
Dec 10, 2025
Use the new macros to make request struct parsing / field swapping much easier. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
metux
force-pushed
the
pr/dbe-use-request-head-struct-and-request-field-macros-_2025-12-03_13-27-09
branch
from
31352ea to
1f76bf9
Compare
algrid
reviewed
Dec 23, 2025
| if (client->swapped) { | ||
| xDbeSwapInfo *pSwapInfo; | ||
| if (stuff->n == 0) | ||
| return Success; |
There was a problem hiding this comment.
Technically it should be after the REQUEST_FIXED_SIZE below to make sure that the request has the correct size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new macros to make request struct parsing / field swapping
much easier.
Signed-off-by: Enrico Weigelt, metux IT consult info@metux.net