feat: deploy all in on on docker #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengmk2
force-pushed
the
deploy-on-docker
branch
from
6479059 to
b13157b
Compare
fengmk2
added a commit
to cnpm/cnpmcore
that referenced
this pull request
Jun 17, 2023
make it easy to run on docker env X-Profiler/all-in-one#2
|
SGTM |
fengmk2
added a commit
to cnpm/cnpmcore
that referenced
this pull request
Jun 17, 2023
make it easy to run on docker env X-Profiler/all-in-one#2
|
如果有个 docker compose 一键部署就方便太多了! |
|
另外 dockerfile 没有处理时区? |
|
应用层已经是 timestamp 了，展示序列化需要有时区 |
|
比如这个时间我昨天测试的时候是不对的(应该是 2024-01-10 14:23:49 ), 后边通过手动改dockerfile 改成shanghai的时区解决的 假设系统用utc, 在应用层面切换时区, 会更友好, 就不用改Dockerfile了 |
|
@defp 来个 PR，这块确实可以优化下 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1