-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate helm notes #92
base: 3.x
Are you sure you want to change the base?
Conversation
02f5ad3
to
d4d742e
Compare
@theturtle32 Merged your other PR's and released them in v4.0.2 an hour ago. Do you want to do anything to this PR before I review it? Put this up for v5 as it's a breaking change. |
Is it really any more of a breaking change than the other PR that removed the escaping from the undocumented If it would help, we could leave that one alone without modification, and just add two more, so you would have three outputs:
This would make it not a "breaking" change and allow for it to be released in the 4.x series. Thoughts? Opinions on naming? |
Honestly, I considered that a bug fix to a feature. Strictly speaking, it was undocumented and making any changes to it isn't a BC break.
Works for me 👍
Well |
Building on the Multiline Output fix in #85, this PR splits helm's
NOTES.txt
output from the rest of the output, and populates separate Github Actions outputs for each. This makes it easier to render theNOTES.txt
into the Markdown-formatted workflow summary.PR #85 should be merged first, as this PR is dependent upon it and includes its changes as well.
The two outputs are:
helm_output
– Everything that was output by thehelm
command before the lineNOTES:
helm_notes
– Everything that was output by thehelm
command after the lineNOTES:
I also updated the README to document the new outputs.