Fixed a problem with sorting of tags #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a problem where sorting of multiple tags which where created on the same date would not work correctly. Now instead it sorts on the date first and if multiple tags are found on the same date it selects the tag with the "highest" version. For example, earlier if we had two tags with the names: Application-v1.0.0 Application-v1.0.1 Which were created on the same date, the v1.0.0 tag would be selected. Now by also sorting on the refname it will select the tag with the highest version number, i.e Application-v1.0.1 instead.
|
@epm-marcus Looking at why the tests are failing, this shouldn't happen. Might have messed up, will let you know when I fixed them. |
|
@epm-marcus Do you have more details, or even an public repo I can look at. Set up https://github.com/repository-situations/same-day-git-tag for #57 and a few follow up PR's so I can test (edge) cases like this better. But the tests are succeeding on it. Unless I missed something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a problem where sorting of multiple tags which where created on the same date would not work correctly. Now instead it sorts on the date first and if multiple tags are found on the same date it selects the tag with the "highest" version. For example, earlier if we had two tags with the names: Application-v1.0.0
Application-v1.0.1
Which were created on the same date, the v1.0.0 tag would be selected. Now by also sorting on the refname it will select the tag with the highest version number, i.e Application-v1.0.1 instead.