This repository has been archived by the owner on Jan 9, 2024. It is now read-only.
Changed to https to negate http 301 error & fixed typo on guildList() #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lungyiing
approved these changes
Mar 3, 2017
|
I've only just seen this, I'm not part of the time anymore but another admin might be able to approve it |
|
Yay my first pull request got accepted 😂 Silicon Valley here I come!
…On Fri, 3 Mar 2017, 17:49 Chris Ireland, ***@***.***> wrote:
I've only just seen this, I'm not part of the time anymore but another
admin might be able to approve it
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABU1y7emw2wOZbK8uBdJz81ib6f9I087ks5riFK9gaJpZM4GusaM>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, there were just a couple things that made this API unusable. Firstly, not using https resulted in a site moved response and secondly, guildList() had a missing bracket or something like that. I may upload my caching system if it holds up.
Thanks! --Romaine