New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make scoped_render_pass apply the label to the render pass #86

Merged

Wumpf merged 1 commit into Wumpf:main from Dinnerbone:label

Oct 18, 2024

Contributor

Dinnerbone commented Oct 18, 2024

I found myself needing to basically duplicate the label, and realized the library should probably be doing that for me 😅

If a label on the passed in render_pass is Some, then this won't override it - it just acts as a default.


          Make scoped_render_pass apply the label to the render pass

79ba34b

Dinnerbone force-pushed the label branch from 1a9a625 to 79ba34b Compare

October 18, 2024 17:59

Wumpf approved these changes

View reviewed changes

Owner

Wumpf left a comment

huh, yeah good point. It's already messing with the descriptor and it's also doing that for compute pass!
Thanks!

Wumpf merged commit 39ac2e1 into Wumpf:main

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet