Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot receive the onMessageUpdate callback of failed sending #5

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

tang4595
Copy link
Contributor

@tang4595 tang4595 commented Jul 4, 2024

In the below environment,

Xcode version: 15.3
swift-driver version: 1.90.11.1 Apple Swift version 5.10 (swiftlang-5.10.0.13 clang-1500.3.9.4)
Target: arm64-apple-macosx14.0

In the file WKRetryManager.m, if the failed message enters the resend queue, when the number of retries reaches the maximum, the chatManager delegate will never receive an onMessageUpdate: callback.

Because in the judgment logic of line 368 of the following code, it has been checked whether the maximum number of retries has been exceeded, so the else code of line 378 will never be executed.

Before fixing:
before-fixing

After fixing:
after-fixing

Issue: #4

@tangtaoit tangtaoit merged commit bb0676c into WuKongIM:main Jul 4, 2024
@tangtaoit
Copy link
Contributor

thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants