Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in several dataset using #3

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions hw_asr/datasets/utils.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from operator import xor

from torch.utils.data import DataLoader, ChainDataset
from torch.utils.data import DataLoader, ConcatDataset

import hw_asr.augmentations
import hw_asr.batch_sampler as batch_sampler_module
Expand All @@ -18,8 +18,10 @@ def get_dataloaders(configs: ConfigParser, text_encoder: BaseTextEncoder):
# set train augmentations
if split == 'train':
wave_augs, spec_augs = hw_asr.augmentations.from_configs(configs)
drop_last = True
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ну и добавил drop_last чтобы казусов не было в конце эпохи

else:
wave_augs, spec_augs = None, None
drop_last = False

# create and join datasets
datasets = []
Expand All @@ -29,7 +31,7 @@ def get_dataloaders(configs: ConfigParser, text_encoder: BaseTextEncoder):
wave_augs=wave_augs, spec_augs=spec_augs))
assert len(datasets)
if len(datasets) > 1:
dataset = ChainDataset(datasets)
dataset = ConcatDataset(datasets)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Все датасеты у нас индексированные, а Chain работает только с Iterable

else:
dataset = datasets[0]

Expand All @@ -50,6 +52,8 @@ def get_dataloaders(configs: ConfigParser, text_encoder: BaseTextEncoder):
# create dataloader
dataloader = DataLoader(
dataset, batch_size=bs, collate_fn=collate_fn,
shuffle=shuffle, num_workers=num_workers, batch_sampler=batch_sampler)
shuffle=shuffle, num_workers=num_workers,
batch_sampler=batch_sampler, drop_last=drop_last
)
dataloaders[split] = dataloader
return dataloaders