Added support for triple-quote comments (weird test behavior) #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haxrox
reviewed
Sep 21, 2023
| ) | ||
| # warnings.warn(cmd) | ||
| if self.args.write: | ||
| mod_path = Path(__file__).parent / "bell.sv" |
Collaborator
There was a problem hiding this comment.
How does this syntax work?
Collaborator
There was a problem hiding this comment.
The Path(__file__).parent / "bell.sv"
Owner
Author
There was a problem hiding this comment.
Take the parent of the current file then join with bell.sv
|
|
||
|
|
||
| def fib(n: int): | ||
| """ |
Collaborator
There was a problem hiding this comment.
What's the point of this? Or will the comment be more descriptive in the future?
Owner
Author
There was a problem hiding this comment.
Test to make sure the added feature works.
Users can not have triple-quote comments in the functions they decorate with verilogify.
WorldofKerry
changed the title
WorldofKerry
changed the title
Haxrox
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.