Feat(milestone-card):Added delete functionality #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viv9k
requested changes
May 30, 2023
sanjaykrishna1203
requested changes
May 30, 2023
functions/model/milestone/lib.js
Outdated
Comment on lines
75
to
78
| exports.getAllMilestonesData = function(orgDomain, teamId="") { | ||
| let query = db.collection("Organizations").doc(orgDomain).collection("Milestones"); | ||
| let query = db.collection("Organizations").doc(orgDomain).collection("Milestones").where("MilestoneStatus", "==", "Deleted"); | ||
| if (teamId != "") { | ||
| query = query.where("TeamId", "==", teamId); |
There was a problem hiding this comment.
This will get the deleted Milestones is this the required functionality?
There was a problem hiding this comment.
Actually it is used to fetch the milestone but the condition here is wrong , it should be not equal to "Deleted", I have made the changes in the code as required.
sanjaykrishna1203
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functionality:
Added delete functionality
Solution:
Changes in milestone-card component
WtId: Dev658
Risk level:
How to test:
1.Open emulators
2.Go to milestones
3. Create Milestone
4. you can use delete functionality of milestones