Feature/conjugation preserving normalize for subword #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eiennohito
reviewed
Dec 27, 2021
sudachitra/word_formatter.py
Outdated
| } | ||
| self._format = self.word_form_types[self.word_form_type] | ||
|
|
||
| def format(self, m: Morpheme): |
There was a problem hiding this comment.
At this moment the format function is not very useful, it also adds to the hotpath one more Python function call which are unfortunately not free. Returning a callable instead of making this a class would be probably better.
There was a problem hiding this comment.
There still should be support of processing data in parallel, which probably will use PreTokenizer from SudachiPy, the fix can be delayed till then.
katsutan
reviewed
Dec 27, 2021
t-yamamura
deleted the
feature/conjugation_preserving_normalize_for_subword
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.