Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FED-3207 Add react lazy #406

Merged
merged 15 commits into from
Oct 7, 2024
Merged

FED-3207 Add react lazy #406

merged 15 commits into from
Oct 7, 2024

Conversation

kealjones-wk
Copy link
Collaborator

@kealjones-wk kealjones-wk commented Sep 9, 2024

Adding in a React.lazy implementation

This is part one of FED-3114

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

lib/react_client/react_interop.dart Outdated Show resolved Hide resolved
lib/react_client/react_interop.dart Outdated Show resolved Hide resolved
lib/react_client/react_interop.dart Outdated Show resolved Hide resolved
lib/react_client/react_interop.dart Outdated Show resolved Hide resolved
test/react_lazy_test.dart Show resolved Hide resolved
test/react_lazy_test.dart Show resolved Hide resolved
@rmconsole7-wk rmconsole7-wk changed the title Add react lazy FED-3207 Add react lazy Oct 1, 2024
Copy link
Collaborator

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This looks ready to merge, but before we do that, let's make sure that the over_react PR doesn't need any additional changes (mainly that this thread around the wrapper is addressed)

Copy link
Collaborator

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole4-wk rmconsole4-wk merged commit 9a9899f into master Oct 7, 2024
5 checks passed
@rmconsole4-wk rmconsole4-wk deleted the FED-3114-lazy branch October 7, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants