Skip to content

CPLAT-9057: Implement StrictMode Component #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 23, 2019

Conversation

kealjones-wk
Copy link
Collaborator

Motivation

In order to move ourselves closer to concurrent mode the StrictMode component will help us by alerting devs with console errors about issues that are bad practice, deprecated usages, or will prevent concurrent mode.

StrictMode currently helps with:

  • Identifying components with unsafe lifecycles
  • Warning about legacy string ref API usage
  • Warning about deprecated findDOMNode usage
  • Detecting unexpected side effects
  • Detecting legacy context API

Changes

  • Implemented StrictMode Component interop.
  • Added test for StrictMode rendering.

Copy link
Collaborator

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

@kealjones-wk kealjones-wk marked this pull request as ready for review December 23, 2019 18:23
@kealjones-wk kealjones-wk merged commit f834a56 into master Dec 23, 2019
@kealjones-wk kealjones-wk mentioned this pull request Dec 23, 2019
@greglittlefield-wf greglittlefield-wf deleted the CPLAT-9057-strictmode branch February 16, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants