RM-23161 Implemented LL based Stack & tests #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmconsole3-wf
changed the title
RavenNumber of Findings: 0 |
| @@ -184,6 +184,12 @@ structure which preserve and reuse previous versions. This uses a very | |||
| functional, cons-style of list manipulation. Insert, get, remove, and size | |||
| operations are O(n) as you would expect. | |||
|
|
|||
| #### Stack | |||
|
|
|||
| A persistent, immutable stack providing time efficient operations. All operations are applied to the stack itself and don't need | |||
There was a problem hiding this comment.
This isn't persistent/immutable is it? I'm not saying it should be, but you modify the internal state in all the operations
|
@Spriithy Would you mind addressing @brianshannan-wf 's question? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I saw the lack of a proper stack implementation in your repository, so I made one according to your guidelines & based on your other data structure implementations.
My implementation is a Linked-list based stack with O(1) overhead for Push/Pop operations. Only downside of this technique is space efficiency. But since you can make a stack of pointers, its OK.
Hope it will help!