Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEA-3685: Reverted non-dev bin import usage errors #115

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

matthewnitschke-wk
Copy link
Contributor

@matthewnitschke-wk matthewnitschke-wk commented Apr 29, 2024

FEA-3685

Issue Status

Motivation

One of the new checks within v4 included an invalid assumption: #107

This is simply not true, non-dev dependencies can exist within bin, I was mistaken on the original intent of #106

Changes

Reverted the bad assumption

Testing/QA Instructions

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@matthewnitschke-wk
Copy link
Contributor Author

QA +1

CI passes, is a revert of of a bad release

@bender-wk bender-wk changed the title Reverted non-dev bin import usage errors FEA-3685: Reverted non-dev bin import usage errors Apr 29, 2024
@matthewnitschke-wk
Copy link
Contributor Author

🚀 @Workiva/release-management-p 🚢

Copy link
Contributor

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole2-wf rmconsole2-wf merged commit 688a498 into master Apr 29, 2024
4 checks passed
@rmconsole2-wf rmconsole2-wf deleted the reverted_non-dev_bin_usages branch April 29, 2024 22:07
@matthewnitschke-wk matthewnitschke-wk restored the reverted_non-dev_bin_usages branch April 29, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants