Skip to content

Update to API13 #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 23 commits into from
Closed

Update to API13 #49

wants to merge 23 commits into from

Conversation

Mystic-W
Copy link

Hello. I think I've succesfully updated Craftimizer to API13. I ran it and crafted a few things, opened a few menus, and it seems to be working alright. I'm unable to test it thoroughly. Perhaps offering my fork as a test version through Dalamud's testing feature could work to this end.

Summary of changes:

  • Updated the project to Dalamud API13.
  • Fixed all breaking changes related to ImGui. Biggest one was migrating from ref string to the byte[] buffer pattern for all InputText calls.
  • Updated all ImGui/ImPlot calls to use the new API (e.g., ImTextureID, wrapper types, callbacks).
  • Corrected all outdated Lumina sheet properties (e.g., Recipe.Unknown0 is now Recipe.MaxAdjustableJobLevel.RowId)
  • Resolved various other compile errors related to pointer/handle access and delegate signature changes.
    Testing performed:
  • The plugin loads in-game without any errors in the Dalamud console (waow)
  • I've crafted a few things using the UI.
  • I've opened the main windows and interacted with them (macro editor, settings panels)
  • Recipe data seems to load correctly.

@Mystic-W
Copy link
Author

I've experienced a crash. It's documented here: Mystic-W#1 (comment).
I've attempted to fix it here [37c79ce]. I will keep testing.

@Mystic-W
Copy link
Author

Mystic-W commented Aug 19, 2025

Obsolesced by 050fddb

@Mystic-W Mystic-W closed this Aug 19, 2025
@WorkingRobot
Copy link
Owner

Thank you for your work on it, though! I may reference some of your changes in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants