Add lighthouse scripts #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryelle
approved these changes
Jul 28, 2022
package.json
Outdated
Comment on lines
22
to
24
| "lighthouse": "npm exec -- lighthouse-ci http://localhost:8888/ --accessibility=100 --best-practices=100", | ||
| "lighthouse:desktop": "npm exec -- lighthouse http://localhost:8888/ --view --preset=desktop --output-path=lighthouse.html", | ||
| "lighthouse:mobile": "npm exec -- lighthouse http://localhost:8888/ --view --preset=mobile --output-path=lighthouse.html" |
There was a problem hiding this comment.
Suggested change
| "lighthouse": "npm exec -- lighthouse-ci http://localhost:8888/ --accessibility=100 --best-practices=100", | |
| "lighthouse:desktop": "npm exec -- lighthouse http://localhost:8888/ --view --preset=desktop --output-path=lighthouse.html", | |
| "lighthouse:mobile": "npm exec -- lighthouse http://localhost:8888/ --view --preset=mobile --output-path=lighthouse.html" | |
| "lighthouse": "lighthouse-ci http://localhost:8888/ --accessibility=100 --best-practices=100", | |
| "lighthouse:desktop": "lighthouse http://localhost:8888/ --view --preset=desktop --output-path=lighthouse.html", | |
| "lighthouse:mobile": "lighthouse http://localhost:8888/ --view --preset=mobile --output-path=lighthouse.html" |
|
If we wanted, we could also run the tests on PR or trunk merge and save the artifact within the action. |
|
Yeah I think lighthouse-ci will be useful for that. It's probably not needed at this stage but I might make a draft PR after merging this part. |
`yarn lighthouse:desktop` and `yarn lighthouse:mobile` to view detailed reports with the desktop and mobile preset respectively.
tellyworth
force-pushed
the
add/lighthouse
branch
from
e62de34 to
bdb186d
Compare
Also remove redundant `npm exec`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This installs
lighthouse-ciand adds an easy script for running Lighthouse.Props ,
Screenshots
How to test the changes in this Pull Request:
yarnyarn lighthouseyarn lighthouse:desktopyarn lighthouse:mobile