-
Couldn't load subscription status.
- Fork 207
Reorganized the chapters in the PHP handbook #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've verified this in detail and can confirm this complies with what the PR intends to do and no other textual changes have been made.
Only remark I have is that there are trailing spaces in two places in the file, which should probably be removed (line 358 and line 446).
|
@jrfnl I'm looking at the changes, but cannot see the trailing spaces in my editor. |
Your editor may have removed them, try saving and seeing if there is a diff (and make sure that whitespace is not being ignored for the diff). |
|
Indeed, my PhpStorm didn't show them, but Sublime did 😅 Thanks for catching it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good (@dingo-d You can fix up things like this in the original commit)
|
Just a note for other maintainers, please don't merge this until #92 has been merged. It's going to be easier to fixup this PR than vice versa |
Grouped similar chapters in a logical structure.
4e55913 to
2b5790e
Compare
|
I've rebased the PR so that the code examples are pulled from the master branch. I've found 2 grammar issues (?) that I've replaced:
with
with regards to -> in regard to And
with
Removed the unnecessary more word. If you have any objections to these two changes I can revert them, but they are really minor. Other than that, no content has been changed. |
I don't think this is correct as it changes the meaning of the sentence. Adding a comma might be better ? But if I'm honest, I think the original sentence is correct and the grammar check wrong 😝
|
|
Now that I read it, it does make more sense to leave it as is instead of removing the I blame PhpStorm's grammar checker 😅 Will revert it. The first sentence does need a singular regard, so I'll leave this change 🙂 |
|
@GaryJones @ntwb can you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In terms of ordering, then ✅ - so long as the content is on the page, I don't think it matters too much what order it's in, and if there's some value in aligning with a PSR/external standards, go for it.


Closes #93
Grouped similar chapters in a logical structure.
Reviewing this from a code comparison view might be... challenging.
I recommend just opening the new structure and the old one and comparing if everything was copied over correctly.
The proposed chapter grouping is the following: