Plugin Directory: Consume security scan callbacks exactly once - #805
Closed
obenland wants to merge 3 commits into
Closed
Plugin Directory: Consume security scan callbacks exactly once#805obenland wants to merge 3 commits into
obenland wants to merge 3 commits into
Conversation
Consumed callbacks are recorded per scan_id under a canonical (key-order-insensitive) digest: an identical scanner retry is acknowledged without repeating effects, a different body for a consumed scan is rejected as a conflict, and a completed verdict supersedes an earlier failure report for the same scan — the pending entry survives a failure for exactly that reason. A short per-plugin lock (released even if processing throws) prevents concurrent callbacks from double-processing or clobbering each other's records. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Spun out of #777: the exactly-once consumption of security scan callbacks, independent of any release-blocking policy. Splitting it out lets #795 (and other consumers of scan results) be based on trunk without carrying #777's policy change.
What it does
scan_idunder a canonical (key-order-insensitive) digest: an identical scanner retry — including one that re-marshals the same body with a different key order — is acknowledged without repeating effects, where previously a retry arriving after the pending entry was cleared was rejected as an unknown scan.Testing
tests/Security_Scan_Consumption_Test.php(7 tests) covers the identical replay acknowledged without re-running effects, conflict rejection, a re-marshalled retry with different key order, a completed verdict superseding a failure report, the failure report keeping the pending entry, a mismatched version leaving no consumed record, and the per-plugin lock rejecting a concurrent callback without consuming anything. Full plugin-directory suite passes (206 tests); both files lint clean.🤖 Generated with Claude Code