Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WordPress build] Only build the latest patch version of WordPress #1955
[WordPress build] Only build the latest patch version of WordPress #1955
Changes from 6 commits
6ea3c75
117725b
464c8b3
995dc17
06e4d07
4f3964c
2eb981b
fafe763
7cad147
70939da
3a98021
122ecfa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this issue. If we want to prevent ni0ghtly rebuilds from rerunning, we could store the nightly version as
nighty-YEAR-MONTH-DATE
insteadnightly
. This would prevent a rebuild if a nightly version was already built.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we could have the logged nightly version track the latest commit on WP trunk or something similar and only rebuild if that has changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where would we pull this data from? In GitHub WordPress just keeps pushing commits through the day.
Are there any disadvantages to using a date?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I should've voiced my thoughts about the date suggestion. Sorry about that. It looks like we run nightly once a day at the 9th hour, so avoiding rebuilds within the same day didn't seem helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense! It sounds like the current nightly implementation is ok as is.