[PHP] Suggestion - adding a `cp` method in Universal PHP

[mho22]

While playing with PHP, I found out it has a mv method. I was wondering if a cp method could be useful.

What do you think @adamziel @bgrgicak @brandonpayton ?

[bgrgicak]

I'm surprised that we don't have a cp method, but we have copyRecursive. Would there be any value in having both?

[mho22]

copyRecursive is actually a FSHelper. I was more thinking of a dedicated function for php.ts. Like mv in php.ts file

mv(fromPath: string, toPath: string) {
	const result = FSHelpers.mv(
		this[__private__dont__use].FS,
		fromPath,
		toPath
	);
	this.dispatchEvent({ type: 'filesystem.write' });
	return result;
}

Which calls FSHelpers.mv() inside of it. Just asking out of curiosity of course.

[adamziel]

Adding such a method sounds reasonable, good idea! I think it came up a few times and I was hesitant because of all the ambiguities, e.g. should we differentiate between the semantics of /source/path/ vs /source/path, or what should happen when the target directory already exists, etc. mv is cleaner in that we can just short-circuit in a number of those scenarios. That being said, I don't think we actually do so we might as well create a cp method that is just like mv without the final deletion of the moved files.

[mho22]

I will suggest a pull request soon and base my implementation on how FSHelpers copies files and directories and how php.mv is coded.