Revert "Script Loader: Add sourceURL to inline scripts and styles."#9671
Closed
sirreal wants to merge 1 commit intoWordPress:trunkfrom
Closed
Revert "Script Loader: Add sourceURL to inline scripts and styles."#9671sirreal wants to merge 1 commit intoWordPress:trunkfrom
sirreal wants to merge 1 commit intoWordPress:trunkfrom
Conversation
This appears to cause some issues with the customizer. Revert https://core.trac.wordpress.org/changeset/60685 Revert https://core.trac.wordpress.org/changeset/60686
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
pento
pushed a commit
that referenced
this pull request
Aug 29, 2025
It was discovered that these changes cause some issues in the customizer when `SCRIPT_DEBUG` is `false`. Reverts [60685] and [60686]. Developed in #9671 Props jonsurrell, wildworks, tyxla. See #63887. git-svn-id: https://develop.svn.wordpress.org/trunk@60690 602fd350-edb4-49c9-b593-d223f7449a82
Member
Author
|
Merged in [60690]. |
markjaquith
pushed a commit
to WordPress/WordPress
that referenced
this pull request
Aug 29, 2025
It was discovered that these changes cause some issues in the customizer when `SCRIPT_DEBUG` is `false`. Reverts [60685] and [60686]. Developed in WordPress/wordpress-develop#9671 Props jonsurrell, wildworks, tyxla. See #63887. Built from https://develop.svn.wordpress.org/trunk@60690 git-svn-id: http://core.svn.wordpress.org/trunk@60026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Aug 29, 2025
It was discovered that these changes cause some issues in the customizer when `SCRIPT_DEBUG` is `false`. Reverts [60685] and [60686]. Developed in WordPress/wordpress-develop#9671 Props jonsurrell, wildworks, tyxla. See #63887. Built from https://develop.svn.wordpress.org/trunk@60690 git-svn-id: https://core.svn.wordpress.org/trunk@60026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Member
|
Thanks for fixing this, @sirreal! |
jonnynews
pushed a commit
to spacedmonkey/wordpress-develop
that referenced
this pull request
Sep 24, 2025
It was discovered that these changes cause some issues in the customizer when `SCRIPT_DEBUG` is `false`. Reverts [60685] and [60686]. Developed in WordPress#9671 Props jonsurrell, wildworks, tyxla. See #63887. git-svn-id: https://develop.svn.wordpress.org/trunk@60690 602fd350-edb4-49c9-b593-d223f7449a82
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding
sourceURLseems to cause some issues with the customizer when SCRIPT_DEBUG is set to false.Revert the changes to fix customizer issues.
Revert [60685].
Revert [60686].
Testing (via @t-hamano)
The customizer should load without issues with this patch applied.
See WordPress/gutenberg#71374 (comment).
Trac ticket: https://core.trac.wordpress.org/ticket/63887
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.