-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customize: Resolve horizontal overflow in customizer panel #7811
base: trunk
Are you sure you want to change the base?
Customize: Resolve horizontal overflow in customizer panel #7811
Conversation
Prevent horizontal scrolling caused by overflow in the customizer panel by adjusting overflow-x to hidden.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Hi @SainathPoojary, Thanks for your attempt to fix this issue with your code addition, which visually resolves it. However, upon further inspection, the root of this issue may be related to previous accessibility improvement for accordion component. See this CSS update for reference. This added extra padding in that code part makes the customizer control button a little longer than usual.
That being said, the better fix would be adding box sizing to the button:
What do you think? |
Hi @kharissulistiyo , Thank you for your feedback and for pointing out the root cause. I agree that adding box-sizing: border-box; to the button is a more robust solution to ensure the customizer control button sizing remains consistent, and it should resolve the overflow issue without impacting the layout further. I’ll update the code to include this change. Thanks again for the suggestion! |
Fixes overflow issue in customizer by applying box-sizing: border-box for consistent button sizing.
Trac ticket: #62443
This PR addresses the issue of horizontal overflow in the customizer panel, which was causing unintended horizontal scrolling. The overflow issue has been resolved by modifying the overflow-x to ensure the panel content stays within the bounds of the viewport.
Screenshots: