Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize: Resolve horizontal overflow in customizer panel #7811

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

SainathPoojary
Copy link

Trac ticket: #62443

This PR addresses the issue of horizontal overflow in the customizer panel, which was causing unintended horizontal scrolling. The overflow issue has been resolved by modifying the overflow-x to ensure the panel content stays within the bounds of the viewport.

Screenshots:

image
image

Prevent horizontal scrolling caused by overflow in the customizer panel by adjusting overflow-x to hidden.
Copy link

github-actions bot commented Nov 15, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sainathpoojary, apermo, kharisblank.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

@apermo apermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SainathPoojary SainathPoojary changed the title fix: resolve horizontal overflow in customizer panel Customize: Resolve horizontal overflow in customizer panel Nov 15, 2024
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@kharissulistiyo
Copy link

Hi @SainathPoojary,

Thanks for your attempt to fix this issue with your code addition, which visually resolves it.

However, upon further inspection, the root of this issue may be related to previous accessibility improvement for accordion component. See this CSS update for reference.

This added extra padding in that code part makes the customizer control button a little longer than usual.

padding: 10px 10px 11px 14px;

Screen Shot 2024-11-15 at 22 27 27

That being said, the better fix would be adding box sizing to the button:

.accordion-section-title button.accordion-trigger {
     box-sizing: border-box;
}

What do you think?

@SainathPoojary
Copy link
Author

Hi @kharissulistiyo ,

Thank you for your feedback and for pointing out the root cause.

I agree that adding box-sizing: border-box; to the button is a more robust solution to ensure the customizer control button sizing remains consistent, and it should resolve the overflow issue without impacting the layout further.

I’ll update the code to include this change. Thanks again for the suggestion!

Fixes overflow issue in customizer by applying box-sizing: border-box for consistent button sizing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants