Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Bindings: Bootstrap block bindings sources with inline script from server #7552

Conversation

SantosGuillamot
Copy link

@SantosGuillamot SantosGuillamot commented Oct 11, 2024

Fixes the issue reported here: WordPress/gutenberg#66031

Basically, we need to ensure the bootstrap happens early in the process to ensure extenders code runs after it. The current implementation runs after domReady which seems to be too late.

In this pull request, I propose changing the approach and using an inline script like we are doing for bootstrapping block types.

Trac ticket: https://core.trac.wordpress.org/ticket/62225


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

github-actions bot commented Oct 11, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props santosguillamot, cbravobernal.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Contributor

@cbravobernal cbravobernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Still needs the track ticket to be complete.

@SantosGuillamot
Copy link
Author

Still needs the track ticket to be complete.

I have just created the ticket: https://core.trac.wordpress.org/ticket/62225#ticket

@gziolo
Copy link
Member

gziolo commented Oct 15, 2024

Committed with https://core.trac.wordpress.org/changeset/59238.

@gziolo gziolo closed this Oct 15, 2024
@SantosGuillamot SantosGuillamot deleted the update/bootstrap-block-bindings-sources-with-inline-script branch October 15, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants