Skip to content

PHP 8.4 | wpdb::check_connection(): handle deprecation of mysqli_ping() (Trac 62061) #7374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

PHP 8.4 | wpdb::check_connection(): handle deprecation of mysqli_ping() (Trac 62061) #7374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ae33da
PHP 8.4 | wpdb::check_connection(): handle deprecation of mysqli_ping()
jrfnl Sep 13, 2024
27fc3bb
Add ticket annotation to new test.
hellofromtonya Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/wp-includes/class-wpdb.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2114,7 +2114,8 @@ public function parse_db_host( $host ) {
* @return bool|void True if the connection is up.
*/
public function check_connection( $allow_bail = true ) {
if ( ! empty( $this->dbh ) && mysqli_ping( $this->dbh ) ) {
// Check if the connection is alive.
if ( ! empty( $this->dbh ) && mysqli_query( $this->dbh, 'DO 1' ) !== false ) {
return true;
}

Expand Down
11 changes: 11 additions & 0 deletions tests/phpunit/tests/db.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2455,4 +2455,15 @@ public function test_use_mysqli_property_access() {

$this->assertTrue( $wpdb->use_mysqli );
}

/**
* Verify "pinging" the database works cross-version PHP.
*
* @ticket 62061
*/
public function test_check_connection_returns_true_when_there_is_a_connection() {
global $wpdb;

$this->assertTrue( $wpdb->check_connection( false ) );
}
}
Loading