Add ability to disable layout controls per block from theme.json#5147
Closed
tellthemachines wants to merge 1 commit intoWordPress:trunkfrom
Closed
Add ability to disable layout controls per block from theme.json#5147tellthemachines wants to merge 1 commit intoWordPress:trunkfrom
tellthemachines wants to merge 1 commit intoWordPress:trunkfrom
Conversation
86 tasks
mukeshpanchal27
approved these changes
Sep 6, 2023
Member
mukeshpanchal27
left a comment
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thanks @tellthemachines for the PR. It looks good to me.
Contributor
Author
|
Committed in r56534. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/59294
Adds PHP changes from WordPress/gutenberg#53378.
This can't really be tested currently as trying to sync trunk with the latest Gutenberg packages causes a fatal error due to some interactivity API specific code.
I guess the best we can do is check that automated tests pass and nothing is broken after the change 😄
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.