Allow blocks to set their own gap in theme.json#2307
Closed
scruffian wants to merge 1 commit intoWordPress:trunkfrom
Closed
Allow blocks to set their own gap in theme.json#2307scruffian wants to merge 1 commit intoWordPress:trunkfrom
scruffian wants to merge 1 commit intoWordPress:trunkfrom
Conversation
Contributor
Author
|
Closing this old PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an update to WordPress/gutenberg#37360 which attempts to allow blocks to still set their own values for
gapwhile still using the--wp--style--block-gapvariable at the root level.To test, use a theme that sets a custom blockGap for a block (for example Skatepark has a custom blockGap for the navigation block). Check that:
--wp--style--block-gapis still defined