WP_Icons_Registry: make Gutenberg-side iteration easier#11047
WP_Icons_Registry: make Gutenberg-side iteration easier#11047mcsf wants to merge 4 commits intoWordPress:trunkfrom
Conversation
This will make it easier to iterate on WP_Icons_Registry in Gutenberg by allowing us to define derived classes (Gutenberg_Icons_Registry extends WP_Icons_Registry) and inherit any methods or constants that are untouched by referenced by the derived class.
This is so that the Gutenberg plugin can easily provide new core icons in between major WordPress releases. On the other hand, we will probably end up redefining whole methods on the Gutenberg side as we improve WP_Icons_Registry, so it may be moot to introduce a filter just for the manifest file.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
We can think about this later on. I don't want to expose things unnecessarily, but still wanted to show the concept. This reverts commit 40dba1d.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
This PR was committed in changeset 61748. |
2 participants
Trac ticket: https://core.trac.wordpress.org/ticket/64651
Context: WordPress/gutenberg#75878
protectedvisibility. It would be nice to include in 7.0 Beta.Trac ticket:
Use of AI Tools
None
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.