REST API: Add 'scaled' to sideload route image_size enum#11015
REST API: Add 'scaled' to sideload route image_size enum#11015adamsilverstein wants to merge 6 commits intoWordPress:trunkfrom
Conversation
When client-side media processing handles big image scaling, the client creates a -scaled version and sideloads it back. The sideload route's image_size enum was missing 'scaled', causing 400 validation errors. This adds 'scaled' to the enum, adds handling in sideload_item() to record the original file and update the attachment to point to the scaled version, and updates the unique filename filter regex to recognize the -scaled suffix.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Add 'scaled' to the image_size enum in wp-api-generated.js to match the PHP route registration change, fixing the git diff --exit-code CI check. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add tests for the new 'scaled' image_size enum value in the sideload endpoint: verifying metadata updates, authentication requirements, route schema, and unique filename handling for the -scaled suffix. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
get_attached_file() can return false when no file is attached. Add a guard to return a WP_Error before calling wp_basename() with a falsy value.
The sideload route uses edit_media_item_permissions_check which returns rest_cannot_edit_image, not rest_forbidden.
| /** | ||
| * Tests sideloading a scaled image for an existing attachment. | ||
| * | ||
| * @ticket 63 |
There was a problem hiding this comment.
Is this a TRAC ticket number from another repository?
Is this correct?
2 participants
Summary
When client-side media processing handles big image scaling, the client creates a
-scaledversion and sideloads it back via the REST API. The sideload route'simage_sizeenum was missingscaled, causing 400 validation errors.This PR:
'scaled'to theimage_sizeenum in the sideload route registrationsideload_item()to record the original file asoriginal_imageand update the attachment to point to the scaled versionfilter_wp_unique_filename()regex to recognize the-scaledsuffix, preventing unwanted numeric suffixesTest plan
original_imageand the scaled file dimensionsTrac ticket: https://core.trac.wordpress.org/ticket/64737