Skip to content

[#47051] Twenty Nineteen theme sub-menu returns error in WAVE accessibility tool #10816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VladimirAus wants to merge 9 commits into
base: trunk
Choose a base branch
from
Open

[#47051] Twenty Nineteen theme sub-menu returns error in WAVE accessibility tool #10816

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f749bba
58849: Document supported for register_rest_route().
VladimirAus Jul 20, 2025
bc9d98c
Merge branch 'WordPress:trunk' into trunk
VladimirAus Jul 21, 2025
7c610a1
Merge branch 'WordPress:trunk' into trunk
VladimirAus Jul 22, 2025
518ef24
Merge branch 'WordPress:trunk' into trunk
VladimirAus Jul 23, 2025
a6c28e9
Merge branch 'WordPress:trunk' into trunk
VladimirAus Jul 25, 2025
efb036c
Reveretd rest API docs.
VladimirAus Jul 25, 2025
bca8e26
Merge branch 'WordPress:trunk' into trunk
VladimirAus Jan 26, 2026
0a5259d
Merge branch 'WordPress:trunk' into trunk
VladimirAus Jan 29, 2026
8b04def
[#47051] Screen reader fix.
VladimirAus Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/wp-content/themes/twentynineteen/inc/icon-functions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@ function twentynineteen_add_dropdown_icons( $item_output, $item, $depth, $args )
// Inject the keyboard_arrow_left SVG inside the parent nav menu item, and let the item link to the parent item.
// @todo Only do this for nested submenus? If on a first-level submenu, then really the link could be "#" since the desire is to remove the target entirely.
$link = sprintf(
'<button class="menu-item-link-return" tabindex="-1">%s',
'<button class="menu-item-link-return" tabindex="-1" aria-label="%s">%s',
esc_attr( sprintf( __( 'Return to %s', 'twentynineteen' ), $item->title ) ),
twentynineteen_get_icon_svg( 'chevron_left', 24 )
);

Expand All @@ -106,7 +107,8 @@ function twentynineteen_add_dropdown_icons( $item_output, $item, $depth, $args )
$icon = twentynineteen_get_icon_svg( 'keyboard_arrow_down', 24 );

$item_output .= sprintf(
'<button class="submenu-expand" tabindex="-1">%s</button>',
'<button class="submenu-expand" tabindex="-1" aria-label="%s">%s</button>',
esc_attr( sprintf( __( 'Expand child menu for %s', 'twentynineteen' ), $item->title ) ),
$icon
);
}
Expand Down
Loading