Use comment status and type to set $maybe_notify default#10489
Use comment status and type to set $maybe_notify default#10489adamsilverstein wants to merge 6 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Co-authored-by: Aaron Jorbin <aaronjorbin@users.noreply.github.com>
b823913 to
87f55c9
Compare
Co-authored-by: Weston Ruter <westonruter@gmail.com>
87f55c9 to
7c217dd
Compare
Co-authored-by: Weston Ruter <westonruter@gmail.com>
| if ( ! ( $comment instanceof WP_Comment ) ) { | ||
| return false; | ||
| } | ||
| $is_note = ( $comment && 'note' === $comment->comment_type ); |
There was a problem hiding this comment.
Thanks to the above, this can now be simplified:
| $is_note = ( $comment && 'note' === $comment->comment_type ); | |
| $is_note = ( 'note' === $comment->comment_type ); |
| */ | ||
| function wp_new_comment_notify_postauthor( $comment_id ) { | ||
| $comment = get_comment( $comment_id ); | ||
| if ( ! ( $comment instanceof WP_Comment ) ) { |
There was a problem hiding this comment.
Note: hereafter in this function, it should really use $comment->comment_ID (or whatever the field is) instead of $comment_id because the get_comment() function has a filtered return value, so a plugin could potentially substitute the comment with something completely different (although they probably wouldn't).
Trac ticket: https://core.trac.wordpress.org/ticket/64217
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.