Skip to content

Use comment status and type to set $maybe_notify default#10489

Open
adamsilverstein wants to merge 6 commits intoWordPress:trunkfrom
adamsilverstein:fix/notification-filter-default
Open

Use comment status and type to set $maybe_notify default#10489
adamsilverstein wants to merge 6 commits intoWordPress:trunkfrom
adamsilverstein:fix/notification-filter-default

Conversation

@adamsilverstein
Copy link
Member

@adamsilverstein adamsilverstein commented Nov 7, 2025

Trac ticket: https://core.trac.wordpress.org/ticket/64217


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props adamsilverstein, westonruter, jorbin.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@adamsilverstein adamsilverstein force-pushed the fix/notification-filter-default branch from b823913 to 87f55c9 Compare February 25, 2026 10:01
Co-authored-by: Weston Ruter <westonruter@gmail.com>
@adamsilverstein adamsilverstein force-pushed the fix/notification-filter-default branch from 87f55c9 to 7c217dd Compare February 25, 2026 10:03
if ( ! ( $comment instanceof WP_Comment ) ) {
return false;
}
$is_note = ( $comment && 'note' === $comment->comment_type );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to the above, this can now be simplified:

Suggested change
$is_note = ( $comment && 'note' === $comment->comment_type );
$is_note = ( 'note' === $comment->comment_type );

*/
function wp_new_comment_notify_postauthor( $comment_id ) {
$comment = get_comment( $comment_id );
if ( ! ( $comment instanceof WP_Comment ) ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: hereafter in this function, it should really use $comment->comment_ID (or whatever the field is) instead of $comment_id because the get_comment() function has a filtered return value, so a plugin could potentially substitute the comment with something completely different (although they probably wouldn't).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants