Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wp cli to set development mode true #95

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Conversation

mikeritter
Copy link
Contributor

Adds instructions to set development mode to true using wp cli in the terminal

Description

Screenshots

Testing Instructions

Adds instructions to set development mode to true using wp cli in the terminal
Copy link

github-actions bot commented Aug 20, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mikeritter <ritterml@git.wordpress.org>
Co-authored-by: juanfra <juanfra@git.wordpress.org>
Co-authored-by: huzaifaalmesbah <huzaifaalmesbah@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

✅ LGTM

README.md Outdated Show resolved Hide resolved
On line 36 I incorrectly typed "true" when the correct value is "theme". This edit corrects the typo.
@huzaifaalmesbah
Copy link
Contributor

Great! This is very helpful and looks good.

Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, we should also remove the --raw flag so that it places the value in a quoted string.

README.md Outdated Show resolved Hide resolved
@juanfra juanfra added [Type] Documentation Improvements or additions to documentation Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code labels Aug 20, 2024
Co-authored-by: Juan Aldasoro <juanfraa@gmail.com>
Copy link
Contributor Author

@mikeritter mikeritter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleaned up code example and corrected typo

Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mikeritter 🚀

@juanfra juanfra merged commit 1146f76 into WordPress:trunk Aug 20, 2024
5 checks passed
@mikeritter mikeritter deleted the patch-1 branch August 20, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code [Type] Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants