Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix group block width for news blog home. #666

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Fix group block width for news blog home. #666

merged 2 commits into from
Nov 5, 2024

Conversation

juanfra
Copy link
Member

@juanfra juanfra commented Nov 5, 2024

Description

Fixes #665

Screenshots

Screen.Recording.2024-11-05.at.10.54.40.mov

Testing Instructions

  1. Go to the site editor.
  2. Edit the home page.
  3. Select the "News blog home" design.
  4. Confirm that the main groups are full width, and that applying the section styles to them doesn't look broken.

Copy link

github-actions bot commented Nov 5, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: juanfra <juanfra@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>
Co-authored-by: richtabor <richtabor@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Nov 5, 2024

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed, this improves it, thank you:

image

Should we apply block-spacing 0 to the wrapping Group block, to zero out the margin between colored sections? Zoom out can "punch through" the top level singular group wrapper and select the items inside. In fact this might also be a solution for #664. See screenshot above.

@juanfra
Copy link
Member Author

juanfra commented Nov 5, 2024

Should we apply block-spacing 0 to the wrapping Group block, to zero out the margin between colored sections?

Sounds good, done ✅

Zoom out can "punch through" the top level singular group wrapper and select the items inside. In fact this might also be a solution for #664. See screenshot above.

It seems that in this context, it can. But it's not behaving like that in pages or posts; that was one of the reasons we ended up having multiple wrapping groups.

@jasmussen
Copy link
Contributor

It seems that in this context, it can. But it's not behaving like that in pages or posts; that was one of the reasons we ended up having multiple wrapping groups.

It seems like this might thread the needle though: allow us to use includes to import the patterns, just wrap it in a single group that sets the block gap. In doing so, we won't need the redundant groups, and zoom out will still select the correct "top level" section for applying section styles. What do you think?

@juanfra
Copy link
Member Author

juanfra commented Nov 5, 2024

@jasmussen Ok, so I checked and to get this behavior, the single group should have the <main> tag.

I definitely prefer to have the landing pages wrapped in a <main> than duplicating patterns. This would be the best option we have at this moment, in my opinion.

I'll open a PR with those changes for you to check out.

@jasmussen
Copy link
Contributor

Thank you! And this PR seems good to go too!

@juanfra juanfra merged commit 1119ce7 into trunk Nov 5, 2024
4 checks passed
@juanfra juanfra deleted the fix/group-width branch November 5, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expected patterns to be fullwidth so that section styles work
2 participants