-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix group block width for news blog home. #666
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Preview changesYou can preview these changes by following the link below: I will update this comment with the latest preview links as you push more changes to this PR. Note The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed, this improves it, thank you:
Should we apply block-spacing 0 to the wrapping Group block, to zero out the margin between colored sections? Zoom out can "punch through" the top level singular group wrapper and select the items inside. In fact this might also be a solution for #664. See screenshot above.
Sounds good, done ✅
It seems that in this context, it can. But it's not behaving like that in pages or posts; that was one of the reasons we ended up having multiple wrapping groups. |
It seems like this might thread the needle though: allow us to use includes to import the patterns, just wrap it in a single group that sets the block gap. In doing so, we won't need the redundant groups, and zoom out will still select the correct "top level" section for applying section styles. What do you think? |
@jasmussen Ok, so I checked and to get this behavior, the single group should have the I definitely prefer to have the landing pages wrapped in a I'll open a PR with those changes for you to check out. |
Thank you! And this PR seems good to go too! |
Description
Fixes #665
Screenshots
Screen.Recording.2024-11-05.at.10.54.40.mov
Testing Instructions