Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Rename "Post format" category to "Post formats" #660

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

juanfra
Copy link
Member

@juanfra juanfra commented Oct 29, 2024

Description

Fixes #658

Renaming the category to "Post formats" (plural), both to fix the typo (there's more than one pattern in the category), and to make it consistent with the other categories.

This involves changing a translatable string, so we should probably involve #polyglots

Screenshots

Screenshot 2024-10-29 at 17 43 33

Testing Instructions

  1. Create a page.
  2. Open the inserter.
  3. Confirm that the category is "Post formats"

@juanfra juanfra added the [Type] Bug An existing feature does not function as intended. label Oct 29, 2024
Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link

github-actions bot commented Oct 29, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: juanfra <juanfra@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>
Co-authored-by: audrasjb <audrasjb@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@carolinan carolinan added the Internationalization (i18n) Issues or PRs related to internationalization efforts label Oct 30, 2024
@jasmussen
Copy link
Contributor

Thank you!

@juanfra juanfra requested a review from audrasjb October 30, 2024 09:38
Copy link
Contributor

@audrasjb audrasjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a GTE and Locale Manager for fr_FR (and core committer) I approve this changes to be included post-String freeze.

@juanfra juanfra merged commit c6935ad into trunk Oct 30, 2024
8 checks passed
@juanfra
Copy link
Member Author

juanfra commented Oct 30, 2024

Thanks!

@juanfra juanfra deleted the fix/post-formats branch October 30, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Bug An existing feature does not function as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename "Post format" category to "Post formats".
4 participants