Add headers #52
Add headers #52
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| }, | ||
| { | ||
| "area": "footer", | ||
| "name": "Footer" | ||
| "name": "footer", | ||
| "title": "Footer" |
There was a problem hiding this comment.
This is the same change as in #55, I wasn't sure which would get merged first.
| "typography": { | ||
| "fontSize": "var:preset|fontSize|medium", | ||
| "fontWeight": "700", | ||
| "letterSpacing": "-2" |
There was a problem hiding this comment.
I see in the figma that for some variations we go with -2 and for some others 0. We may want to revisit this in the future.
Description
Add four header patterns. This PR does not include the headers that are sidebars.
Partial for #37
Testing Instructions
Activate Gutenberg. Note that I am testing with Gutenberg trunk.
If you don't want to test with Gutenberg, then just switch the header patterns manually by inserting them, since you wont see the "Design" panel.
Since the font sizes and font family is not in yet, the main thing to test in this PR is that:
Apply the PR.
Confirm that the default header is used and displays correctly in the editor and front.
Test with different screen widths.
Then select the different heading patterns from the Design panel in the sidebar in the Site Editor, and repeat the test.
There is no need to test the patterns that are added by core. The patterns from the theme should be the four first patterns, at the top of the Design panel.