Conversation
carolinan
commented
Jul 6, 2022
carolinan
commented
- Moved templates and parts to the new folders
- Moved patterns to the new patterns folder
- Updated theme.json to version 2
- Removed some CSS that is no longer needed.
- Removed theme_support that is no longer needed, since it is added automatically.
Move templates and parts to the correct folder Update theme.json version
|
I think this one closes #193 |
Tested, confirmed (chrome, windows 10) |
tt1-blocks/assets/css/blocks.css
Outdated
|
|
||
| hr, | ||
| .wp-block-separator { | ||
| .wp-block-separator :not(.has-text-color) { |
There was a problem hiding this comment.
The old CSS prevented the color options from working.
|
Closes #260 too then |
| * Slug: tt1-blocks/large-text | ||
| * Categories: tt1-blocks | ||
| * Block Types: core/heading | ||
| * ViewportWidth: 1440 |
There was a problem hiding this comment.
It might be Viewport width not ViewportWidth?
But I wonder if this pattern should be removed, does it bring any value?
There was a problem hiding this comment.
(Secondly if the patterns that don't use custom CSS were moved to the pattern directory, the theme would not need to include them...)
There was a problem hiding this comment.
I think it's Viewport width
And about the pattern directory, yes, that would be the case. I've never included a pattern from the directory on a theme yet, don't know if they work fine or if it still needs more work.
There was a problem hiding this comment.
I don't know if it is a true bug or, if there is a limit to how many patterns are loaded from the directory, or something; but it does not work as I expected, if Gutenberg is active:
WordPress/gutenberg#41959
There was a problem hiding this comment.
mmh, I guess we could raise this in core-editor chat? I don't know who works on this. Maybe we could follow up on a future PR.
|
Looks like we lost the separator style on index? I don't know if this is still a WIP, let me know for a full review
|
2 participants
