Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TT1 Blocks layout issues #299

Merged
merged 6 commits into from
Dec 17, 2021
Merged

Fix TT1 Blocks layout issues #299

merged 6 commits into from
Dec 17, 2021

Conversation

kjellr
Copy link
Collaborator

@kjellr kjellr commented Dec 17, 2021 •
edited
Loading

Fixes #298.

  • Template parts no longer inherit the default layout, so I've moved that into the templates themselves in the form of an extra group wrapper.
  • I've updated the navigation block markup to be in sync with latest versions.
  • I've ported over the left/right padding solution from Twenty Twenty-Two. I don't love this being duplicated in multiple themes, but it's what we've got at the moment.

cc @kafleg

Before After
Screen Shot 2021-12-17 at 11 03 50 AM Screen Shot 2021-12-17 at 11 05 12 AM

@kjellr kjellr added the bug Something isn't working label Dec 17, 2021
@kjellr kjellr self-assigned this Dec 17, 2021
MaggieCabrera
MaggieCabrera approved these changes Dec 17, 2021
View reviewed changes
Copy link
Collaborator

@MaggieCabrera MaggieCabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, I wonder when will this theme be ready for a v1? if we make it ready for 5.9 maybe?

@kjellr
Copy link
Collaborator Author

kjellr commented Dec 17, 2021

Thanks! I'm not sure about a v1! Probably needs a little more attention and cleanup before then.

@MaggieCabrera MaggieCabrera mentioned this pull request Dec 17, 2021
Closed
3 tasks
@kjellr
Copy link
Collaborator Author

kjellr commented Dec 17, 2021

@MaggieCabrera mind giving it one more look after 0248eba?

@kafleg
Copy link
Member

kafleg commented Dec 17, 2021

This PR looks good to me. Thank you @kjellr

@MaggieCabrera
Copy link
Collaborator

@MaggieCabrera mind giving it one more look after 0248eba?

yes, that looks much better, thanks! 🚢

@kjellr kjellr merged commit 5814997 into master Dec 17, 2021
@kjellr kjellr deleted the fix/tt1-layout branch December 17, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaggieCabrera MaggieCabrera MaggieCabrera approved these changes

@scruffian scruffian Awaiting requested review from scruffian

@carolinan carolinan Awaiting requested review from carolinan

Assignees

@kjellr kjellr

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TT1 Blocks: Visual issues
3 participants
@kjellr @kafleg @MaggieCabrera