Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emptytheme: Stop clearing presets #295

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

kjellr
Copy link
Collaborator

@kjellr kjellr commented Dec 16, 2021

Emptytheme contains the following code in its theme.json, which is a helpful starting place for theme authors to populate:

		"color": {
			"gradients": [],
			"palette": []
		},
		"typography": {
			"fontFamilies": [],
			"fontSizes": []
		},

... but the downside is that this clears out those presets, and makes their associated tools unavailable (as noticed by @jasmussen here).

I think it makes sense to remove them.

Copy link
Collaborator

@MaggieCabrera MaggieCabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, I thought about it but never got to make a PR, LGTM!

@scruffian scruffian merged commit caaf21f into master Dec 16, 2021
@scruffian scruffian deleted the try/emptytheme-remove-cleared-presets branch December 16, 2021 12:42
@jasmussen
Copy link

Nice one. I was about to ask for the default color palette to also work, but you're on top of it. Sweet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants