Bugfixes in SHOW CREATE TABLE and SHOW TABLES #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a series of crashes encountered when * SHOW TABLES now returns a flat list, not an array of objects * `SHOW tables` isn't all uppercase * There's no table tho SHOW CREATE: `SHOW CREATE TABLE _no_such_table;` * The table identifier passed to SHOW CREATE is quoted: ``` 'SHOW CREATETABLE `_tmp_table`;' ```
adamziel
changed the title
|
This solves a real problem so I'll go ahead and merge, but let's revisit in case there's more to
|
adamziel
added a commit
that referenced
this pull request
Jun 6, 2024
There's more nuance to the type of the returned value than #117 antitipated. With that PR in, WooCommerce wouldn't work: ``` [06-Jun-2024 16:21:26 UTC] PHP Fatal error: Uncaught TypeError: get_object_vars(): Argument #1 ($object) must be of type object, string given in /wordpress/wp-includes/class-wpdb.php:3 Stack trace: ``` Let's revert and revisit later on
Merged
adamziel
added a commit
that referenced
this pull request
Jun 6, 2024
There's more nuance to the type of the returned value than #117 antitipated. With that PR in, WooCommerce wouldn't work: ``` [06-Jun-2024 16:21:26 UTC] PHP Fatal error: Uncaught TypeError: get_object_vars(): Argument #1 ($object) must be of type object, string given in /wordpress/wp-includes/class-wpdb.php:3 Stack trace: #0 /wordpress/wp-includes/class-wpdb.php(3): get_object_vars('wp_wc_product_a...') #1 /wordpress/wp-content/plugins/woocommerce/src/Internal/ProductAttributesLookup/LookupDataStore.php(69): wpdb->get_var('SHOW TABLES LIK...') #2 /wordpress/wp-content/plugins/woocommerce/src/Internal/ProductAttributesLookup/LookupDataStore.php(650): Automattic\WooCommerce\Internal\ProductAttributesLookup\LookupDataStore->check_lookup_table_exists() ``` Let's revert and revisit later on cc @bgrgicak @wojtekn
adamziel
added a commit
that referenced
this pull request
Aug 11, 2024
There's more nuance to the type of the returned value than #117 antitipated. With that PR in, WooCommerce wouldn't work: ``` [06-Jun-2024 16:21:26 UTC] PHP Fatal error: Uncaught TypeError: get_object_vars(): Argument #1 ($object) must be of type object, string given in /wordpress/wp-includes/class-wpdb.php:3 Stack trace: ``` Let's revert and revisit later on
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a series of crashes encountered when
$tables = $wpdb->get_results("SHOW TABLES LIKE '{$prefix}%'", ARRAY_N);work as expected here, but is the right thing to return, or is this more about correct handling of the fetch mode, like ARRAY_N?SHOW tablesisn't all uppercaseSHOW CREATE TABLE _no_such_table;This PR makes the Sandbox site plugin work in Playground
cc @bgrgicak @brandonpayton @wojtekn