Block Bindings: Add editor preview to acf-field source. #175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Right now, the experience with block bindings in SCF is not the best. The image block binding is broken. There is an extra warning from array to string conversion, and all the block binding place holders are just the default placeholder. (With the SCF Fields name)
without_pr.mov
This PR enhances the experience on the editor by using the new Editor APIs. Now only we use the getValues one. Preventing from edition, but #173 already allows to edit them too.
I need some more testing with different field types for editing. But with this PR, we cover all block bindings supported blocks and their attributes with field types like select, checkbox, url, text field, textareas and numbers.
Why
To enhance the editor experience with block bindings and custom fields.
Screenshare and how to test.
after_pr.mov
Create a custom post type, a field group, some fields.
Use the code to link those fields with their respective blocks, sharing an example so you can copy-paste:
Heading
Image
Button