Fix: SCF Blocks are now forced into preview mode when editing a synced pattern. #135
+3
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priethor
reviewed
May 15, 2025
| @@ -110,7 +110,7 @@ const md5 = require( 'md5' ); | |||
| * @return boolean | |||
| */ | |||
| function isSiteEditor() { | |||
| return typeof pagenow === 'string' && pagenow === 'site-editor'; | |||
| return document.querySelectorAll( 'iframe[name="editor-canvas"]' ).length > 0; | |||
There was a problem hiding this comment.
Is this backported 1:1? Is there any other condition that makes this iframe check more accurate than just wp.data.select('core/edit-site') to know if we are in the Site Editor?
|
I'm going to merge the PR for early "prod" testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Before this PR. SCF blocks could be on "edit" mode inside synced patterns. Now they are forced to be in preview mode, which is the block that the user will see both in editor and in frontend.
ACF 6.4.1 backport.
How to test
Before:
trunk.mov
After:
branch.mov