Allow runtime-set in Abstract_PHP_CodeSniffer_Check class and implement it in I18n_Usage_Check

[ernilambar]

Fixes #679

• Accepts runtime-set arguments in an array form( key value pair)

Example implementation:

return array(
  'extensions'  => 'php',
  'standard'    => 'WordPress',
  'sniffs'      => 'WordPress.WP.I18n',
  'runtime-set' => array(
    'text_domain' => 'sample-domain',
  ),
);

Edit:

• Implement runtime-set text_domain in I18n_Usage_Check class
• Update i18n related tests as now errors will be increased
• Update other test files where i18n_usage check was used for the errors

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <rabmalin@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Co-authored-by: davidperezgar <davidperez@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[swissspidy]

Example implementation:

Are you gonna do that in a follow-up PR?

[ernilambar]

Example implementation:

Are you gonna do that in a follow-up PR?

I could not find idea to get slug value in that protected function get_args(). We don't have context or result object passed to there.

[swissspidy]

We can make get_args() accept a Check_Result as a param and then pass $result to get_args() here:

plugin-check/includes/Checker/Checks/Abstract_PHP_CodeSniffer_Check.php

Lines 82 to 86 in 6418d8d

	// Create the default arguments for PHPCS.
	$defaults = $this->get_argv_defaults( $result );
	// Set the check arguments for PHPCS.
	$_SERVER['argv'] = $this->parse_argv( $this->get_args(), $defaults );

[ernilambar]

@swissspidy ok. That will afect lots of files. Separate pr makes sense?

[swissspidy]

Up to you :-)

[swissspidy]

Niiice!

[davidperezgar]

Wow! Awesome!