Warn if requires headers are not same in readme and plugin header

[ernilambar]

Readme:

• Check if “Requires at least” and “Requires PHP” are the same when they exists in both readme and plugin headers.

Even though core does not use above headers present in readme file, directory still parses headers from readme. So those cannot be removed from readme file at least for now.

[swissspidy]

Even though core does not use above headers present in readme file, directory still parses headers from readme.

But only as a fallback, right?
I‘d love to move people away from this eventually.

[ernilambar]

Even though core does not use above headers present in readme file, directory still parses headers from readme.

But only as a fallback, right? I‘d love to move people away from this eventually.

Does not seem so. Values from readme is fetched and attached to the plugin. And same value is used everywhere. I don't find such fallback like you mentioned. https://github.com/WordPress/wordpress.org/blob/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-upload-handler.php#L445

[swissspidy]

Hmm that's only in the uploader then, but in the importer the plugin file takes precedence. See https://meta.trac.wordpress.org/ticket/4514 / WordPress/wordpress.org@0ae655c

I think that uploader file should be adjusted accordingly.

Ideally we ask developers to only put it in one place. No reason to have that in two places...

[davidperezgar]

I believe this is a tool for best practices. We warn users to not make things that It will be fixed before it uploads to wp.org. We were agreed to include in this plugin.