Open
Description
Proposal 1:
Change error type
Code | Current Type | Proposed Type |
---|---|---|
invalid_license | WARNING | ERROR |
license_mismatch | WARNING | ERROR |
Proposal 2:
Currently same error code no_license
is used for missing license in readme and plugin header which is confusing. Similar for invalid_license
.
My proposal is keeping same error code for readme and add introduce separate error code for plugin header license check:
- plugin_header_no_license
- plugin_header_invalid_license
Proposal 3:
Regarding license check:
- Check one - Check if License is valid SPDX identifier (We could use error code like
invalid_license_identifier
andplugin_header_invalid_license_identifier
) - Check two - Check if License is GPL compatible (Use existing error code for this -
invalid_license
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment