Skip to content

Add metadiff command to Makefile. #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2020
Merged

Conversation

getsource
Copy link
Member

First run at adding a helper script for creating diffs for
updating the plugin in the meta repo.

Adding for discussion.

Is this actually useful / should it be in this repo?
If so, is this where it should live?

First run at adding a helper script for creating diffs for
updating the plugin in the meta repo.
@pfefferle
Copy link
Member

Was your trac MR merged? The diff file is empty on my machine.

@getsource
Copy link
Member Author

If you mean https://meta.trac.wordpress.org/changeset/9884, yes, it was!

Should be able to test by changing any of the PHP involved, or readme.txt.

@pfefferle pfefferle marked this pull request as ready for review May 20, 2020 08:38
Copy link
Member

@pfefferle pfefferle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Works like a charm!

@getsource getsource merged commit e4aca65 into WordPress:master May 20, 2020
@getsource getsource deleted the metadiff branch May 20, 2020 10:09
getsource added a commit to getsource/phpunit-test-reporter that referenced this pull request Sep 17, 2020
After WordPress#80, `make test` started to fail following `make metadiff`.
This resolves the issue by ignoring the build directory when running `phpcs`.
getsource added a commit to getsource/phpunit-test-reporter that referenced this pull request Sep 17, 2020
After WordPress#80, `make test` started to fail following `make metadiff`.
This resolves the issue by ignoring the build directory when running `phpcs`.

See: WordPress#85
getsource added a commit to getsource/phpunit-test-reporter that referenced this pull request Sep 18, 2020
After WordPress#80, `make test` started to fail following `make metadiff`.
This resolves the issue by ignoring the build directory when running `phpcs`.

See: WordPress#85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants